Add explicit support to GitHub Actions scripts for ".test/config.sh" …#47
Conversation
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 76.83% 76.83%
=======================================
Files 5 5
Lines 587 587
=======================================
Hits 451 451
Misses 104 104
Partials 32 32 Continue to review full report at Codecov.
|
|
More complicated success: docker-library/docker#368 |
…(and ".test/tests/xxx/")
| "set -- " + (.tags[0] | @sh), | ||
| # https://github.com/docker-library/bashbrew/issues/46#issuecomment-1152567694 (allow local test config / tests) | ||
| "if [ -s ./.test/config.sh ]; then set -- --config ~/oi/test/config.sh --config ./.test/config.sh \"$@\"; fi", | ||
| "~/oi/test/run.sh \"$@\"" |
There was a problem hiding this comment.
Could you echo to gha output that you used the override config
So people do not have to debug the script
There was a problem hiding this comment.
If you look at https://github.com/tianon/dockerfiles/runs/6889534295?check_suite_focus=true#step:7:10, we run all these with set -x so we kind of get that "for free" 😅
There was a problem hiding this comment.
Ah nice, explicit github ci output would be nice but okay for me 😆
|
I tried this out and had this error in my output: https://github.com/williamdes/docker/runs/7055760237?check_suite_focus=true#step:7:14 |
|
I think you need to move the |
|
Thanks to the new action is is simpler to make this work: phpmyadmin/docker#389 |
4 participants
…(and ".test/tests/xxx/")
Tested successfully via tianon/dockerfiles#223 😄
Closes #46
If
.test/config.shexists, it will be injected via--configontest/run.sh, which then also allows for additional tests in.test/tests/foo/run.sh.